[Bug 89772] New: xf86-video-ati-git unstable

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

Bug ID: 89772
Summary: xf86-video-ati-git unstable
Product: xorg
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: Driver/Radeon
Assignee: xorg-driver-***@lists.x.org
Reporter: ***@gmail.com
QA Contact: xorg-***@lists.x.org

Hello,

after Michael implemented DRI3 I was excited to test it, but the latest git
makes my system quite unstable (even with DRI3 off).

The easiest way for me to test this is to start a game with nine. I am not sure
why but on bad xf86-video-ati-git alt-tab within the game restarts the whole
Xorg (I'm guessing it crashed and was auto-restarted).

I've bisected it, and the result is quite surprising to me but...:

af1862a37570fa512a525ab47d72b30400d2e2d6 is the first bad commit
commit af1862a37570fa512a525ab47d72b30400d2e2d6
Author: Michel DÀnzer <***@amd.com>
Date: Wed Mar 18 11:05:40 2015 +0900

Always include misync.h before other misync headers

Older versions of xserver didn't include misync.h from other misync
headers as needed.

Before this commit I don't have stability issues.
(I've been using xf86-video-ati-git for a while and never had issues till the
batch of DRI3 patches came in).

I have a R7 280x, on Linux 4.0-rc4 and Xorg 1.17, mesa-git and llvm-svn.

Thanks!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #1 from John <***@gmail.com> ---
Created attachment 114635
--> https://bugs.freedesktop.org/attachment.cgi?id=114635&action=edit
dmesg after the restart of Xorg

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #2 from John <***@gmail.com> ---
Created attachment 114636
--> https://bugs.freedesktop.org/attachment.cgi?id=114636&action=edit
Xorg log after Xorg restarted

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #3 from John <***@gmail.com> ---
Created attachment 114637
--> https://bugs.freedesktop.org/attachment.cgi?id=114637&action=edit
Xorg log of the previous Xorg session, including the crash information

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|***@daenzer.net |

--- Comment #4 from Michel DÀnzer <***@daenzer.net> ---
Does the patch from bug 89681 help?

If not, can you get a backtrace of the crash with gdb, and double-check that
the git bisect result is correct? It really doesn't make sense for that commit
to be the culprit, in particular with DRI3 disabled.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #5 from John <***@gmail.com> ---
I got a crash in the commit I thought was safe, so I guess it's more randomized
than I thought. I was fine for about an hour and then got it...

The patch did not help either, although that other bug describes pretty much
the behavior I am seeing (and I'm also using KDE if that matters).

I'll try to find the correct git commit and then the backtrace.

Thanks!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #6 from John <***@gmail.com> ---
Alright so far I've had that issue as early as commit:
6c3a721cde9317233072b573f9502348dcd21b16 DRI2: Use helper functions for DRM
event queue management v3.

I'll keep using a build at the previous commit for a day or so before calling
it good, but I've already used it for about half a day without issue.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #7 from John <***@gmail.com> ---
So it's been about a day and still no issue on
commit c3fa22a479e61d1899fa9d327d9c4e2a7f64b0c1
DRI2: Move radeon_dri2_flip_event_handler

Since the problem is not as easy to trigger as I thought, it could not be it,
but for now I'd say the problem came from the following commit:
6c3a721cde9317233072b573f9502348dcd21b16
DRI2: Use helper functions for DRM event queue management v3.

Next step is to get the gdb backtrace, hopefully I can manage today.

Thanks

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #8 from John <***@gmail.com> ---
Created attachment 114690
--> https://bugs.freedesktop.org/attachment.cgi?id=114690&action=edit
gdb trace of Xorg crashing

Alright that was easier than I expected!
Though my distribution does not provide debug packages for Xorg... for now only
the ddx driver has its debug information. I hope that's enough.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #9 from John <***@gmail.com> ---
Created attachment 114693
--> https://bugs.freedesktop.org/attachment.cgi?id=114693&action=edit
new gdb log with debug symbols

Actually rebuilding Xorg with symbols was fairly easy.
Also, if that matters, my new quick way of getting it to crash is loading XBMC
and then switching from window to fullscreen till it crashes, that usually
takes few tries, but I don't think it's a sure way either.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #10 from Michel DÀnzer <***@daenzer.net> ---
Is this still an issue with current xf86-video-ati Git master?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #11 from John <***@gmail.com> ---
Created attachment 114716
--> https://bugs.freedesktop.org/attachment.cgi?id=114716&action=edit
new gdm log with latest git

I was unable to quickly crash it with xbmc, but it did quickly crash with
wine/nine, so no master is still not good.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #12 from John <***@gmail.com> ---
Created attachment 114717
--> https://bugs.freedesktop.org/attachment.cgi?id=114717&action=edit
xorg log with latest git

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #13 from John <***@gmail.com> ---
Created attachment 114718
--> https://bugs.freedesktop.org/attachment.cgi?id=114718&action=edit
and dmesg as well

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

John <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #114716|new gdm log with latest git |new gdb log with latest git
description| |

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #14 from Michel DÀnzer <***@daenzer.net> ---
Created attachment 114720
--> https://bugs.freedesktop.org/attachment.cgi?id=114720&action=edit
Use radeon_get_pixmap_handle() in radeon_dri2_schedule_flip()

Does this patch fix it?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #15 from John <***@gmail.com> ---
No it's the same as latest master.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #16 from Michel DÀnzer <***@daenzer.net> ---
Please attach another gdb backtrace with the patch applied.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #17 from John <***@gmail.com> ---
Alright. I just have to switch room for the 2nd computer everytime so I got
lazy this time :)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #18 from John <***@gmail.com> ---
Alright. I just have to switch room for the 2nd computer everytime so I got
lazy this time :)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #19 from John <***@gmail.com> ---
Created attachment 114722
--> https://bugs.freedesktop.org/attachment.cgi?id=114722&action=edit
gdb trace of Xorg crashing with that patch

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #114720|0 |1
is obsolete| |

--- Comment #20 from Michel DÀnzer <***@daenzer.net> ---
Created attachment 114741
--> https://bugs.freedesktop.org/attachment.cgi?id=114741&action=edit
Only enable SYNC extension fences and the Present extension along with DRI3

Does this patch avoid the problem?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #21 from John <***@gmail.com> ---
So far I have not seen any crash with this patch with xbmc or wine, so this may
be the correct patch, but as I don't always crash let's give it a day or so
before calling it correct.


Also, should I try with DRI3 or stick to DRI2 for now?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #22 from John <***@gmail.com> ---
So it's been a few days now, I can't say that I tried really hard to make it
crash, but so far I got no crash so I think the patch is good.

Now I should turn on DRI3 and see what that changes.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #23 from Michel DÀnzer <***@daenzer.net> ---
Fix pushed to Git. Leaving this report open until you confirm it doesn't happen
with DRI3 enabled.

commit 98fb4199e63fedd4607cddee64bf602d6398df81
Author: Michel DÀnzer <***@amd.com>
Date: Tue Mar 31 12:25:18 2015 +0900

Only enable SYNC extension fences and the Present extension along with DRI3

This avoids some trouble with the Gallium nine state tracker, which uses
the Present extension even when DRI3 is disabled.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #24 from John <***@gmail.com> ---
Unfortunately I had it in a few minutes once I turned DRI3 on.
I will attach logs once I get gdb running.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #25 from John <***@gmail.com> ---
Created attachment 114846
--> https://bugs.freedesktop.org/attachment.cgi?id=114846&action=edit
dri3 gdb log

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #26 from John <***@gmail.com> ---
Created attachment 114847
--> https://bugs.freedesktop.org/attachment.cgi?id=114847&action=edit
dri3 xorg log

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #27 from John <***@gmail.com> ---
Created attachment 114848
--> https://bugs.freedesktop.org/attachment.cgi?id=114848&action=edit
dri3 dmesg

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #28 from sarnex <***@gmail.com> ---
This appears to be the issue that I was explaining to MrCooper. Same crash on
DRI3 and Nine when Alt-Tabbing. Really strange. Let me know if I can help.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #29 from John <***@gmail.com> ---
If you can help, feel free to :)

In this case, I wonder if the issues I had with wine, and the ones with xbmc
were somewhat unrelated even if the end result was the same, as I usually was
able to easily trigger one but not the other at times.

I've been on dri2 since my last post and didn't have any Xorg crash... so
Michel's latest patch has been great for DRI2, but I am still waiting for
something on DRI3.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #30 from John <***@gmail.com> ---
Is there anything I can add to the report to help?
Thanks!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #31 from Michel DÀnzer <***@daenzer.net> ---
Created attachment 115107
--> https://bugs.freedesktop.org/attachment.cgi?id=115107&action=edit
Handle NULL bo in can_exchange()

Does this patch fix the problem with DRI3 enabled?

If yes, can you try reverting patch 114741 and seeing if the problem is still
reproducible with DRI3 disabled?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #32 from John <***@gmail.com> ---
Thank you for the patch Michel.
Unfortunately I am having some unrelated computer issue right now, and may not
be able to test this for a few days.
I'll get back to you as soon as I can.

Thanks!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #33 from sarnex <***@gmail.com> ---
(In reply to Michel DÀnzer from comment #31)

Created attachment 115107 [details] [review]
Handle NULL bo in can_exchange()
Does this patch fix the problem with DRI3 enabled?
If yes, can you try reverting patch 114741 and seeing if the problem is
still reproducible with DRI3 disabled?

Hi Michel.

The patch has no effect for me. X still dies when I Alt-Tab out of a game. I've
linked below to some debug info from Wine that may be useful. I only see these
PRESENT errors right before X crashes after the alt-tab.

Log: http://pastebin.com/raw.php?i=zAM4YJuA

Hope this helps,
sarnex

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #34 from Michel DÀnzer <***@daenzer.net> ---
(In reply to sarnex from comment #33)

Post by b***@freedesktop.org
The patch has no effect for me. X still dies when I Alt-Tab out of a game.

Please attach a gdb backtrace of the Xorg crash with that patch applied.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #35 from sarnex <***@gmail.com> ---
(In reply to Michel DÀnzer from comment #34)

Post by b***@freedesktop.org
(In reply to sarnex from comment #33)

Post by b***@freedesktop.org
The patch has no effect for me. X still dies when I Alt-Tab out of a game.

Please attach a gdb backtrace of the Xorg crash with that patch applied.

Hi Michel,

I've attached the backtrace. I got it twice and the backtrace was the same.

Backtrace: http://pastebin.com/raw.php?i=KyjRtCaq

Hope it helps,
sarnex

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #36 from John <***@gmail.com> ---
Thanks for doing this for me Sarnex!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #37 from Michel DÀnzer <***@daenzer.net> ---
(In reply to sarnex from comment #35)

Post by b***@freedesktop.org
I've attached the backtrace. I got it twice and the backtrace was the same.
Backtrace: http://pastebin.com/raw.php?i=KyjRtCaq

Thanks, but for the future, when I say 'attach' I mean using the 'Add an
attachment' link on this page.

AFAIR you already pastebinned the same backtrace earlier on IRC, so it's
probably not related to the patch and not the same crash as John's. Please file
your own report.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #38 from sarnex <***@gmail.com> ---
(In reply to Michel DÀnzer from comment #37)

Post by b***@freedesktop.org
(In reply to sarnex from comment #35)

Post by b***@freedesktop.org
I've attached the backtrace. I got it twice and the backtrace was the same.
Backtrace: http://pastebin.com/raw.php?i=KyjRtCaq

Thanks, but for the future, when I say 'attach' I mean using the 'Add an
attachment' link on this page.
AFAIR you already pastebinned the same backtrace earlier on IRC, so it's
probably not related to the patch and not the same crash as John's. Please
file your own report.

Done. Sorry for the ignorance and noise.

Sarnex

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #39 from John <***@gmail.com> ---
So I just tried with the new patch and it didn't crash when I alt-tabbed, BUT
it kind of froze the UI.

All I found was this line in Xorg.log:
"[ 364.633] (II) AIGLX: Suspending AIGLX clients for VT switch".

It could be unrelated to the patch so let me try a few more things before.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #40 from John <***@gmail.com> ---
oh and by froze the UI, I mean I could hear the music, when I alt-tabbed I got
to see my other window, I could see the mouse moving, but that was it, I could
not interact with anything, switch desktops or alt-tab back.
I was able to switch VTs back and forth though.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #41 from John <***@gmail.com> ---
Just tried with the same xf86-video-ati-git package, but disabling DRI3 in
xorg.conf and this time it worked fine... so I guess it's either DRI3 or the
way nine uses it.

Would there be any use in a gdb trace as Xorg didn't crash this time? I'm not
sure if I'd even get something...

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #42 from Michel DÀnzer <***@daenzer.net> ---
Note that the problem actually happens during a DRI2 page flip operation. Any
idea whether it's the app or compositor (which one are you using, BTW?) which
is falling back to DRI2?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #43 from John <***@gmail.com> ---
I am unable to answer that question, it's too deep for me, maybe Sarnex can.

But I am using kwin_x11 as my compositor. Is there any special settings you'd
like me to try there?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #44 from Michel DÀnzer <***@daenzer.net> ---
Does the current master branch of
git://people.freedesktop.org/~daenzer/xf86-video-ati help for this?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #45 from John <***@gmail.com> ---
This branch is partially better, so we have some progress!


The good part is it doesn't seem to crash with your new changes. I have not
tried it extensively, but with the standard master I usually crash X at my
first-tab.

The bad part is I don't really get a correct alt-tab behavior, meaning if I tab
out of the game I expect to only see the other window (konsole in my case), but
with this branch it keeps flipping back and forth between the 2.
I can alt-tab fine between chromium windows though.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #46 from John <***@gmail.com> ---
Oh with this branch and dri3 on, I get visual corruptions inside of XBMC/Kodi,
but only in the menus, not while playing a movie.
Switching dri3 off removes that problem.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #47 from Michel DÀnzer <***@daenzer.net> ---
I've updated that branch again, does it work better now?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #48 from John <***@gmail.com> ---
I just tried and the behavior is the same.

Something I have noticed though, is that I can alt-tab fine during the
in-game-loading screen, but past it I get the issue... No idea what this means
but it might help.

Is there any native DRI3 app you think I should try, to see if my issue at this
point is not in nine instead of the ddx?

Thank you for keeping at this!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #49 from Michel DÀnzer <***@daenzer.net> ---
(In reply to John from comment #48)

Post by b***@freedesktop.org
Is there any native DRI3 app you think I should try, to see if my issue at
this point is not in nine instead of the ddx?

Apps don't use DRI3 or DRI2 directly. If you enable DRI3 for the Mesa build,
OpenGL apps should use DRI3. With current Mesa Git, the debugging output
enabled by LIBGL_DEBUG=verbose explicitly says whether it's using DRI3 or DRI2.

I don't have nine set up yet, but I was able to reproduce issues when running
kwin with DRI3 and xbmc with DRI2 (via LIBGL_DRI3_DISABLE=1) and switching
between fullscreen and windowed mode in xbmc, which those changes fix for me.
Can you confirm that?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #50 from John <***@gmail.com> ---
(In reply to Michel DÀnzer from comment #49)

Post by b***@freedesktop.org
Apps don't use DRI3 or DRI2 directly. If you enable DRI3 for the Mesa build,
OpenGL apps should use DRI3. With current Mesa Git, the debugging output
enabled by LIBGL_DEBUG=verbose explicitly says whether it's using DRI3 or
DRI2.

Cool!

Post by b***@freedesktop.org
I don't have nine set up yet, but I was able to reproduce issues when
running kwin with DRI3 and xbmc with DRI2 (via LIBGL_DRI3_DISABLE=1) and
switching between fullscreen and windowed mode in xbmc, which those changes
fix for me. Can you confirm that?

Hmmm, I had issues with XBMC going fullscree to window a while back, but you
fixed them, so I am not sure what you are asking me to confirm here.
I just tried with dri3 enabled and LIBGL_DRI3_DISABLE=1 and kodi behaves fine,
or did you want me to switch to the standard branch before testing this?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #51 from Michel DÀnzer <***@daenzer.net> ---
(In reply to John from comment #50)

Post by b***@freedesktop.org
(In reply to Michel DÀnzer from comment #49)

With current Mesa Git, the debugging output enabled by LIBGL_DEBUG=verbose
explicitly says whether it's using DRI3 or DRI2.

Cool!

Does it say DRI3 or DRI2 for you?


Branch updated again with another attempt, does that work better?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #52 from John <***@gmail.com> ---
It said what I expected (dri3 when not using the disable command option, dri2
when using it).

I'll try your new branch and report a bit later.

Thanks!

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #53 from John <***@gmail.com> ---
It's the same behavior with the latest pull from your branch.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #54 from John <***@gmail.com> ---
So I had not tested this in a while, but it seems to be fixed now.
I just did a quick alt-tab test with Heroes Of the Storm and it looked fine.

I have no clue what fixed it, since then there's been changes in the DDX, Mesa
and Linux.. but maybe it is time to close this.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

Michel DÀnzer <***@daenzer.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #55 from Michel DÀnzer <***@daenzer.net> ---
(In reply to John from comment #54)

Post by b***@freedesktop.org
So I had not tested this in a while, but it seems to be fixed now.
I just did a quick alt-tab test with Heroes Of the Storm and it looked fine.

Great, resolving this report as fixed, thanks for the update. Please reopen
this report if the problem occurs again.

BTW, you did test with DRI3 enabled, right? :)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

--- Comment #56 from John <***@gmail.com> ---
I believe so yes :)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89772

John <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED